Skip to content

[Woo Pos] FF, entry point and empty pos activity #11502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2024
Merged

[Woo Pos] FF, entry point and empty pos activity #11502

merged 4 commits into from
May 13, 2024

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented May 13, 2024 •
edited
Loading

Closes: #11494

Description

Adds:

  • POS FF
  • POS button that visible when FF is on in the "more" screen
  • Dummy POS activity

Testing instructions

  • Make sure that in release mode the POS button is not visible and visible and opens POS activity in debug mode

Images/gif

05-13--17-03.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov linked an issue May 13, 2024 that may be closed by this pull request
[Woo POS] FF, Entry point, empty POS activity #11494
Closed
@kidinov kidinov requested a review from samiuelson May 13, 2024 15:05
@kidinov kidinov added the feature: point of sale POS project label May 13, 2024
@kidinov kidinov added this to the 18.7 milestone May 13, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitc6199cc
Direct Downloadwoocommerce-prototype-build-pr11502-c6199cc.apk

@samiuelson samiuelson self-assigned this May 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 40.83%. Comparing base (796a359) to head (c6199cc).

Files Patch % Lines
...ocommerce/android/ui/woopos/root/WooPosActivity.kt 0.00% 10 Missing ⚠️
...ocommerce/android/ui/moremenu/MoreMenuViewModel.kt 66.66% 3 Missing ⚠️
...m/woocommerce/android/ui/woopos/IsWooPosEnabled.kt 0.00% 2 Missing ⚠️
...kotlin/com/woocommerce/android/util/FeatureFlag.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              trunk   #11502      +/-   ##
============================================
- Coverage     40.83%   40.83%   -0.01%     
  Complexity     5180     5180              
============================================
  Files          1068     1070       +2     
  Lines         62285    62308      +23     
  Branches       8496     8498       +2     
============================================
+ Hits          25437    25444       +7     
- Misses        34561    34576      +15     
- Partials       2287     2288       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiuelson
samiuelson approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@samiuelson samiuelson merged commit 30bb126 into trunk May 13, 2024
14 of 19 checks passed
@samiuelson samiuelson deleted the 11494-woo-pos-ff-entry-point-empty-pos-activity branch May 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiuelson samiuelson samiuelson approved these changes

Assignees

@samiuelson samiuelson

Labels
feature: point of sale POS project
Projects
None yet
Milestone
18.7
Development

Successfully merging this pull request may close these issues.

[Woo POS] FF, Entry point, empty POS activity
4 participants
@kidinov @wpmobilebot @codecov-commenter @samiuelson